> On June 20, 2016, 10:20 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 1495 > > <https://reviews.apache.org/r/48991/diff/1/?file=1425964#file1425964line1495> > > > > You don't need `endl` for LOG
Thanks. I will address it. > On June 20, 2016, 10:20 p.m., Avinash sridharan wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 1493 > > <https://reviews.apache.org/r/48991/diff/1/?file=1425964#file1425964line1493> > > > > Can we use `LOG` here. This is a helper process, not the Agent process, > > not sure if `glog` has been initialized in the helper process. > > > > Since we are using `cerr` to log output from helper process should we > > use `cerr` with a (WARNING) tag? LOG(WARNING) should be appropriate. Please see launch/executor.cpp - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48991/#review138760 ----------------------------------------------------------- On June 20, 2016, 7:46 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48991/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 7:46 p.m.) > > > Review request for mesos, Avinash sridharan, Guangya Liu, Artem Harutyunyan, > Jie Yu, and Qian Zhang. > > > Bugs: MESOS-5669 > https://issues.apache.org/jira/browse/MESOS-5669 > > > Repository: mesos > > > Description > ------- > > Added exception for etc hostname mount in cni isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 9fc709e95ecff7e97e159ed05a4efcf4e887d5e0 > > Diff: https://reviews.apache.org/r/48991/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
