----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49000/#review138812 -----------------------------------------------------------
Patch looks great! Reviews applied: [49001, 49000] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On June 21, 2016, 5:05 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49000/ > ----------------------------------------------------------- > > (Updated June 21, 2016, 5:05 a.m.) > > > Review request for mesos, Abhishek Dasgupta, zhou xing, Jay Guo, haosdent > huang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This change performs the following function definition reordering: > > - It groups pre v1 API/v1 Master API handlers nearby for better > readability. There were already some functions already doing this. > - For some handlers that use a helper function, it defines them > _before_ the HELP string variable. This means that now the > HELP strings immediatly precede the handler implementation > which is more intuitive to the reader. > > > Diffs > ----- > > src/master/http.cpp 3a53ef74f3e80e832804a21cebe0fc9e405420cb > > Diff: https://reviews.apache.org/r/49000/diff/ > > > Testing > ------- > > make check (would be doing a similar change for the agent) > > > Thanks, > > Anand Mazumdar > >
