----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47972/#review138783 -----------------------------------------------------------
Fix it, then Ship it! Just some minor suggestions. 3rdparty/stout/tests/os/rmdir_tests.cpp (line 334) <https://reviews.apache.org/r/47972/#comment203974> Nit: Capitalization, unless the first word refers to a special term like 'mknod' etc. 3rdparty/stout/tests/os/rmdir_tests.cpp (lines 342 - 346) <https://reviews.apache.org/r/47972/#comment203975> I commented on this earlier: can't we just ``` const string directory = "direcotry"; ``` ? 3rdparty/stout/tests/os/rmdir_tests.cpp (line 351) <https://reviews.apache.org/r/47972/#comment203977> s/mountPoint/mountPoint_/ You use `this->` below to distinguish this temp variable and the member variable but we generally just avoid name collision. Suffix _ is commmonly used for this. 3rdparty/stout/tests/os/rmdir_tests.cpp (line 364) <https://reviews.apache.org/r/47972/#comment203979> ``` // Register the mount point for cleanup. mountpoint = mountPoint_; ``` - Jiang Yan Xu On June 18, 2016, 8:50 p.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47972/ > ----------------------------------------------------------- > > (Updated June 18, 2016, 8:50 p.m.) > > > Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, and > Jiang Yan Xu. > > > Bugs: MESOS-5196 > https://issues.apache.org/jira/browse/MESOS-5196 > > > Repository: mesos > > > Description > ------- > > Updates made to rmdir to prevent early exit in the event of error. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/rmdir.hpp > 4780a13465ee1323c49db9911bc7083173cfe0df > 3rdparty/stout/include/stout/os/windows/rmdir.hpp > 772b86dd111d28aefbeeba5f829ffa377fd12efb > 3rdparty/stout/tests/os/rmdir_tests.cpp > a11bfc9f9e6cbb05f3e9ce0ea48297b8f88fe53f > > Diff: https://reviews.apache.org/r/47972/diff/ > > > Testing > ------- > > testing done with 'make check'. > > > Thanks, > > Megha Sharma > >
