> On June 23, 2016, 5:12 p.m., Zhitao Li wrote: > > include/mesos/master/master.proto, line 279 > > <https://reviews.apache.org/r/49155/diff/1/?file=1428639#file1428639line279> > > > > I think we should unified messages for different `Get*` calls in the V1 > > API. > > > > IMO, the current json based endpoints are a bit difficult and confusing > > to use, because all of them have slight different return values even if > > returning same logical object like Framework or Task. And there is little > > reason they should differ. > > > > Also, given that we are introducing a new versioned API, we don't > > really need to guarantee byte level compatibility of existing unversioned > > endpoints. Functional equivalency should be sufficent. > > > > Can you take a look at new messages defined at > > https://reviews.apache.org/r/48751/ and comment on what additions or > > changes we need for them?
+1 - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49155/#review139274 ----------------------------------------------------------- On June 23, 2016, 3:15 p.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49155/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 3:15 p.m.) > > > Review request for mesos, Anand Mazumdar, zhou xing, haosdent huang, Vinod > Kone, and Zhitao Li. > > > Bugs: MESOS-5490 > https://issues.apache.org/jira/browse/MESOS-5490 > > > Repository: mesos > > > Description > ------- > > Implement GET_STATE_SUMMARY Call in v1 master API. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > src/master/http.cpp 70f084b84db90fde20c05d2354be190f28e72996 > src/master/master.hpp e983d1ba6ebcdaf2ace419201659e53edaa2a0aa > src/tests/api_tests.cpp 7f16f43c3968cd56cf93951489079032093beaeb > > Diff: https://reviews.apache.org/r/49155/diff/ > > > Testing > ------- > > WIP > > make check on Ubuntu 14.04 > > It would be good to have common proto message `agent` and `framework`, since > they are being used in API `get_state`, `get_agent`, `get_framework`, even > though not entirely identical. > > > Thanks, > > Jay Guo > >
