----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47973/#review139382 -----------------------------------------------------------
Ship it! LGTM. Caught two styling issues which I will fix when committing. src/tests/gc_tests.cpp (line 857) <https://reviews.apache.org/r/47973/#comment204583> Two spaces here. src/tests/gc_tests.cpp (line 984) <https://reviews.apache.org/r/47973/#comment204582> One blank line below. - Jiang Yan Xu On June 23, 2016, 10:32 a.m., Megha Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47973/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 10:32 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-5196 > https://issues.apache.org/jira/browse/MESOS-5196 > > > Repository: mesos > > > Description > ------- > > It's possible for tasks and isolators to lay down files that are not > deletable by GC. In the face of such errors GC needs to free up disk > space wherever it can because it's already re-offered to frameworks. > > > Diffs > ----- > > src/slave/gc.cpp eedb8ca713d7f5195055bb6417f03ab70731af97 > src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 > > Diff: https://reviews.apache.org/r/47973/diff/ > > > Testing > ------- > > Testing done with 'make check'. > > > Thanks, > > Megha Sharma > >
