----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/#review139406 -----------------------------------------------------------
include/mesos/master/master.proto (lines 291 - 295) <https://reviews.apache.org/r/49136/#comment204627> instead of state lets just have `bool active` and `bool connected` fields like we do in the internal master::Framework struct. we can introduce state later when we actually introduce a state in the internal struct. include/mesos/master/master.proto (lines 310 - 315) <https://reviews.apache.org/r/49136/#comment204628> as zhitao mentioned, lets use required fields for things that we know are required for now. this will be consistent with scheduler and executor apis. include/mesos/master/master.proto (line 317) <https://reviews.apache.org/r/49136/#comment204626> it is a bit inconsistent to represent completed tasks via `completed_tasks` but completed frameworks via a state variable in `Framework`. lets represent completed fraemworks as `completed_frameworks` for now. include/mesos/master/master.proto (line 323) <https://reviews.apache.org/r/49136/#comment204629> don't need this? looks like this is just the sum of the next 2? - Vinod Kone On June 24, 2016, 7:21 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49136/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 7:21 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5492 > https://issues.apache.org/jira/browse/mesos-5492 > > > Repository: mesos > > > Description > ------- > > Add 'Framework' protobuf message to master/master.proto & > v1/master/master.proto. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > > Diff: https://reviews.apache.org/r/49136/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
