----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/#review139592 -----------------------------------------------------------
Fix it, then Ship it! Looks good. I think this is sufficient to unblock me for GetState. Thanks. include/mesos/v1/master/master.proto (line 296) <https://reviews.apache.org/r/49136/#comment204841> Should this be required? I guess that's the case for any custom executor type, but I'm not sure about CommandExecutor. - Zhitao Li On June 27, 2016, 7:47 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49136/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 7:47 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5492 > https://issues.apache.org/jira/browse/mesos-5492 > > > Repository: mesos > > > Description > ------- > > Add 'Framework' protobuf message to master/master.proto & > v1/master/master.proto. > > > Diffs > ----- > > include/mesos/master/master.proto 639fbd110df4aca1cf700cb9e455eecc110a7f66 > include/mesos/v1/master/master.proto > 11dfab318eb073908a9e302afa33b274fec63a16 > > Diff: https://reviews.apache.org/r/49136/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
