----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/#review139459 -----------------------------------------------------------
src/Makefile.am (line 1028) <https://reviews.apache.org/r/49219/#comment204688> I think the runtime.cpp also need to put into CMakeLists.txt https://github.com/apache/mesos/blob/master/src/CMakeLists.txt#L160 src/slave/containerizer/mesos/isolators/appc/runtime.hpp (line 28) <https://reviews.apache.org/r/49219/#comment204689> s/APPC/AppC src/slave/containerizer/mesos/isolators/appc/runtime.hpp (lines 36 - 38) <https://reviews.apache.org/r/49219/#comment204690> This was not needed in your isolator src/slave/containerizer/mesos/isolators/appc/runtime.hpp (lines 44 - 59) <https://reviews.apache.org/r/49219/#comment204691> I think those functions can be removed as you will only need `prepare()` for this isolator. - Guangya Liu On 六月 25, 2016, 5:21 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49219/ > ----------------------------------------------------------- > > (Updated 六月 25, 2016, 5:21 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added runtime isolator interface to run appc containers. > > > Diffs > ----- > > src/Makefile.am 23cac95a805e46d216e9479fea09f2c1619c45a5 > src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49219/diff/ > > > Testing > ------- > > Make Check > > > Thanks, > > Srinivas Brahmaroutu > >
