----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49219/#review139785 -----------------------------------------------------------
Another comment is I'm not sure which name is better `AppCRuntimeIsolatorProcess` or `AppcRuntimeIsolatorProcess`? Seems the latter one is better. @Gilbert and @Jie, what do you think? - Guangya Liu On 六月 28, 2016, 5:54 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49219/ > ----------------------------------------------------------- > > (Updated 六月 28, 2016, 5:54 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added runtime isolator interface to run appc containers. > > > Diffs > ----- > > src/CMakeLists.txt ecdeee75abfca944bc2ac1da4962d8d50e236d2d > src/Makefile.am 23cac95a805e46d216e9479fea09f2c1619c45a5 > src/slave/containerizer/mesos/isolators/appc/runtime.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49219/diff/ > > > Testing > ------- > > Make Check > > > Thanks, > > Srinivas Brahmaroutu > >
