----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46686/#review139482 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/include/process/dispatch.hpp (line 72) <https://reviews.apache.org/r/46686/#comment204737> ``` template <typename R> struct Dispatch; 3rdparty/libprocess/include/process/dispatch.hpp (lines 75 - 76) <https://reviews.apache.org/r/46686/#comment204734> ``` // Partial specialization for callable objects returning `void` to be dispatched // on a process. ``` 3rdparty/libprocess/include/process/dispatch.hpp (line 82) <https://reviews.apache.org/r/46686/#comment204730> Let's not force a construction of `std::function` here, since the `F&&` being forwarded could be a lambda or other callable objects. ``` - void operator()(const UPID& pid, const std::function<void()>& f) + template <typename F> + void operator()(const UPID& pid, F&& f) ``` 3rdparty/libprocess/include/process/dispatch.hpp (lines 95 - 96) <https://reviews.apache.org/r/46686/#comment204735> ``` // Partial specialization for callable objects returning `Future<R>` to be // dispatched on a process. ``` 3rdparty/libprocess/include/process/dispatch.hpp (line 102) <https://reviews.apache.org/r/46686/#comment204731> Same comment as the `void` case. 3rdparty/libprocess/include/process/dispatch.hpp (line 119) <https://reviews.apache.org/r/46686/#comment204733> `s/other types/R/` 3rdparty/libprocess/include/process/dispatch.hpp (lines 119 - 120) <https://reviews.apache.org/r/46686/#comment204736> ``` // Dispatches a callable object returning `R` on a process. ``` 3rdparty/libprocess/include/process/dispatch.hpp (line 126) <https://reviews.apache.org/r/46686/#comment204732> Same comment as the `void` case. - Michael Park On June 24, 2016, 8:56 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46686/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 8:56 a.m.) > > > Review request for mesos, Kevin Klues and Michael Park. > > > Bugs: MESOS-4611 > https://issues.apache.org/jira/browse/MESOS-4611 > > > Repository: mesos > > > Description > ------- > > Allowed to pass lambda in `dispatch`. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/dispatch.hpp > 9e36047bfde39ccfdd5151639931a46d24e419c8 > > Diff: https://reviews.apache.org/r/46686/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
