> On June 25, 2016, 3:26 p.m., Tomasz Janiszewski wrote:
> > src/webui/master/static/js/controllers.js, line 162
> > <https://reviews.apache.org/r/49228/diff/1/?file=1430179#file1430179line162>
> >
> >     Probably `task.state` could be used here.
> 
> Vinod Kone wrote:
>     yup. just use `task.state` here

Done


- Tomasz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49228/#review139446
-----------------------------------------------------------


On June 27, 2016, 10:03 a.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49228/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 10:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and 
> Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Only set the terminal time if the last state is terminal.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js 
> be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 
> 
> Diff: https://reviews.apache.org/r/49228/diff/
> 
> 
> Testing
> -------
> 
> Generate orpahne tasks that is alive. It should have not set stopped time.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to