> On June 27, 2016, 5:17 p.m., haosdent huang wrote: > > src/webui/master/static/js/controllers.js, line 158 > > <https://reviews.apache.org/r/49228/diff/2/?file=1430958#file1430958line158> > > > > `function (task)` should be `function(task)`
Thanks. We should add jslint to this project as a first step to add tests for UI. - Tomasz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49228/#review139605 ----------------------------------------------------------- On June 27, 2016, 5:26 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49228/ > ----------------------------------------------------------- > > (Updated June 27, 2016, 5:26 p.m.) > > > Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Only set the terminal time if the last state is terminal. > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > be3fa1f1fba9eda7ebcc9bf33142fe4307dd8d90 > > Diff: https://reviews.apache.org/r/49228/diff/ > > > Testing > ------- > > Generate orpahne tasks that is alive. It should have not set stopped time. > > > Thanks, > > Tomasz Janiszewski > >
