----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48372/#review139704 -----------------------------------------------------------
Ship it! src/slave/containerizer/containerizer.cpp (lines 105 - 108) <https://reviews.apache.org/r/48372/#comment205026> No need for this comment, seems to just describe "what" the code does. src/slave/containerizer/containerizer.cpp (line 111) <https://reviews.apache.org/r/48372/#comment205025> Whoops, we should include context to the caller in this error message: ``` return Error("Failed to obtain GPU resources: " + gpus.error()); ``` src/slave/containerizer/containerizer.cpp (lines 114 - 117) <https://reviews.apache.org/r/48372/#comment205027> I assume this is why you added the filter? ``` // When adding in the GPU resources, make sure that we filter out // the existing GPU resources (if any) so that we do not double // allocate GPUs. ``` - Benjamin Mahler On June 23, 2016, 4:33 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48372/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 4:33 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5558 > https://issues.apache.org/jira/browse/MESOS-5558 > > > Repository: mesos > > > Description > ------- > > Updated `Containerizer::resources()` to use the `NvidiaGpuAllocator`. > > > Diffs > ----- > > src/slave/containerizer/containerizer.cpp > 5dc545bd201dca7d751ac4e7dd09d4eac07d428e > > Diff: https://reviews.apache.org/r/48372/diff/ > > > Testing > ------- > > GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests > > > Thanks, > > Kevin Klues > >
