-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48375/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-5563
https://issues.apache.org/jira/browse/MESOS-5563
Repository: mesos
Description
-------
Previously, components outside of
`src/slave/containerizers/mesos/isolators/gpu` had to protect their
\#includes for certain Nvidia header files with the
ENABLE_NVIDIA_GPU_SUPPORT flag. Other headers strictly *could not* be
wrapped in this flag.
This commit cleans up this header madness, by creating a common
"nvidia.hpp" header that takes care of all the dependencies. All
componenents outside of `src/slave/containerizers/mesos/isolators/gpu`
now only need to \#include this one header instead of managing
everything themselves.
Diffs
-----
src/Makefile.am 29525c960e8fb2448260efdd774fd8fc1d68047b
src/slave/containerizer/containerizer.cpp
faa0c789dda8a6f36fdb6217b0bae270b6b8f2e2
src/slave/containerizer/docker.hpp 311dca23ac17fb533866aba1de2b81d750bbe6df
src/slave/containerizer/mesos/containerizer.hpp
a1a00020668f6da8d611f26e5637afffc87d09ba
src/slave/containerizer/mesos/containerizer.cpp
c7b9744463cf8e1921dcb5e2b7dec7d4e2c0e45f
src/slave/containerizer/mesos/isolators/gpu/components.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/gpu/isolator.hpp PRE-CREATION
src/slave/containerizer/mesos/isolators/gpu/nvidia.hpp
f290e3c1d1114698039a505e972793dc325c7100
src/slave/containerizer/mesos/isolators/gpu/nvidia.cpp
7849e518af448d9557ca4d6de4ccaba8bc572992
src/tests/containerizer/nvidia_gpu_isolator_tests.cpp
b1e64b2fc5518463cd14e119f89e3cd298286052
Diff: https://reviews.apache.org/r/48375/diff/
Testing
-------
GTEST_FILTER="" make -j check && sudo GTEST_FILTER="*NVIDIA*" src/mesos-tests
Thanks,
Kevin Klues
