> On June 28, 2016, 6:39 p.m., Vinod Kone wrote: > > include/mesos/master/master.proto, line 316 > > <https://reviews.apache.org/r/49136/diff/7/?file=1431526#file1431526line316> > > > > s/agent_id/slave_id/ > > > > also should this be required?
i've fixed these while committing. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49136/#review139835 ----------------------------------------------------------- On June 28, 2016, 8:09 a.m., zhou xing wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49136/ > ----------------------------------------------------------- > > (Updated June 28, 2016, 8:09 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Bugs: mesos-5492 > https://issues.apache.org/jira/browse/mesos-5492 > > > Repository: mesos > > > Description > ------- > > Add 'Framework' protobuf message to master/master.proto & > v1/master/master.proto. > > > Diffs > ----- > > include/mesos/master/master.proto f63cc5a9dc379e4e264fe1f08fdc06d8c16d7384 > include/mesos/v1/master/master.proto > d98281d58daa461ce622af49adff9f748b920b7f > > Diff: https://reviews.apache.org/r/49136/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > zhou xing > >
