----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36816/#review139934 -----------------------------------------------------------
Can you add a test? - Timothy Chen On June 29, 2016, 4:45 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36816/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 4:45 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Benjamin Mahler, and > Timothy Chen. > > > Bugs: MESOS-2533 > https://issues.apache.org/jira/browse/MESOS-2533 > > > Repository: mesos > > > Description > ------- > > Supported HTTP/HTTPS in health check. > > > Diffs > ----- > > include/mesos/mesos.proto 5b15a89bbac0b33c77e305c5b188823f2704a653 > include/mesos/v1/mesos.proto a1435278e81c8f3179d94cd9d2c3dd8c0ba82d35 > src/health-check/main.cpp 4cc9dde8927acd4594477476f1b1bdc43963d789 > > Diff: https://reviews.apache.org/r/36816/diff/ > > > Testing > ------- > > * Add unit test cases: HealthCheckTest.HealthyTaskViaHttp and > HealthCheckTest.HealthyTaskNotMatchHttpStatuses > make check > > > Thanks, > > haosdent huang > >
