----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49352/#review140009 -----------------------------------------------------------
src/common/parse.hpp (lines 150 - 152) <https://reviews.apache.org/r/49352/#comment205342> Call `insert` directly should be fine. `set` will help to avoid duplicated item. - Klaus Ma On June 29, 2016, 8:12 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49352/ > ----------------------------------------------------------- > > (Updated June 29, 2016, 8:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5743 > https://issues.apache.org/jira/browse/MESOS-5743 > > > Repository: mesos > > > Description > ------- > > Added a flag parser for hashset<std::string>. > > > Diffs > ----- > > src/common/parse.hpp 19e56dbeb765f8bec92e0a3615f6f7c12466fa9e > > Diff: https://reviews.apache.org/r/49352/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
