> On 六月 29, 2016, 11:07 p.m., Benjamin Mahler wrote: > > src/common/parse.hpp, line 144 > > <https://reviews.apache.org/r/49352/diff/1/?file=1432428#file1432428line144> > > > > Can we use std::set for now?
As I want to check if there are duplicate items in the flag of `allocator_fairness_excluded_resource_names`, so here seems `hashset` is a good option as I can check if there are duplicate items via `contains` method. So here I would prefer to use `hashset` but return some error if there are some duplicate items, comments? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49352/#review140068 ----------------------------------------------------------- On 六月 29, 2016, 12:12 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49352/ > ----------------------------------------------------------- > > (Updated 六月 29, 2016, 12:12 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5743 > https://issues.apache.org/jira/browse/MESOS-5743 > > > Repository: mesos > > > Description > ------- > > Added a flag parser for hashset<std::string>. > > > Diffs > ----- > > src/common/parse.hpp 19e56dbeb765f8bec92e0a3615f6f7c12466fa9e > > Diff: https://reviews.apache.org/r/49352/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
