> On June 29, 2016, 10:53 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 1468 > > <https://reviews.apache.org/r/49394/diff/1/?file=1433184#file1433184line1468> > > > > each parameter should be on a different line. but if you make the > > change above, this will only take `principal`.
The method now only takes principal, so this is not relevant anymore. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49394/#review140047 ----------------------------------------------------------- On June 30, 2016, 11:43 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49394/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 11:43 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Adds an intermediate function `Master::http::_flags()` which performs > authorization and it is called by both the endpoint `/flags` handler > and the HTTP API v1 call `flags` handler. > > > Diffs > ----- > > src/master/http.cpp e5acdb8e0bbcd7a2b7e8a8bc7f4bbeaae2c4fea1 > src/master/master.hpp e2ab2110fe5a287ab16ac9ef4222fed633e02ebe > > Diff: https://reviews.apache.org/r/49394/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
