> On June 30, 2016, 8:05 a.m., Adam B wrote: > > src/common/http.cpp, line 712 > > <https://reviews.apache.org/r/49369/diff/1/?file=1432816#file1432816line712> > > > > By making this function return a Try<bool>? > > SGTM, but we can do that in a separate patch, for all the approveX's
We discussed that a bit earlier and decided to first not expose the error (because it requires a longer discussion how the error is handled on the caller side), as `approveX` is internal interface we can change that without external API changes. - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/#review140117 ----------------------------------------------------------- On June 30, 2016, 11:41 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49369/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 11:41 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-5709 > https://issues.apache.org/jira/browse/MESOS-5709 > > > Repository: mesos > > > Description > ------- > > Previously only /weights was filtered but /roles actually > contains the same information and hence both endpoints > should be filtered in the same way. > As part of this work we renamed the GetWeight action to > ViewRole (and same for the acls). > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > a6d93cd2cb9161a98565b22e50b06aac4931a671 > include/mesos/authorizer/authorizer.proto > fc76796022a6fa3d36a1447c476980868d42c2d0 > src/authorizer/local/authorizer.cpp > 3fade4168face1cb80b30c9b69b31d9eb4126222 > src/common/http.hpp 55bd0ac81af80c656a4a80766a3e4b21db9cf0cf > src/common/http.cpp 95e8fb672b49a00860c64f818cc734fa22cf3516 > src/master/http.cpp e089fe960779f39b3321f2ec81ab2acc17d53641 > src/master/weights_handler.cpp 0332d86570724e841f97348087808081b2b890af > src/tests/authorization_tests.cpp 9b99da138fa27a725738d70bd99e889b108b44ae > src/tests/dynamic_weights_tests.cpp > c67ed75a050b9db5575ac2bb6100bcf01cfc04ff > src/tests/master_authorization_tests.cpp > 81804e0522fd6b26155732af08e33c4d0bb0a8fe > > Diff: https://reviews.apache.org/r/49369/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > >
