----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49369/#review140231 -----------------------------------------------------------
include/mesos/authorizer/acls.proto (line 167) <https://reviews.apache.org/r/49369/#comment205546> "(including weights)" should be next to "roles" ? src/master/http.cpp (line 2750) <https://reviews.apache.org/r/49369/#comment205547> extra blank line. src/master/http.cpp (line 2763) <https://reviews.apache.org/r/49369/#comment205548> extra blank line. src/master/http.cpp (line 2822) <https://reviews.apache.org/r/49369/#comment205550> hmm. why pull this out? why not just do this in an foreach loop like we did everywhere else we used approvers? src/master/http.cpp (line 2853) <https://reviews.apache.org/r/49369/#comment205549> can you please fix this as well? also you need to fix the GET_WEIGHTS call. src/tests/master_authorization_tests.cpp (line 1699) <https://reviews.apache.org/r/49369/#comment205554> move this to #1733. src/tests/master_authorization_tests.cpp (lines 1700 - 1701) <https://reviews.apache.org/r/49369/#comment205553> move this to #1724 - Vinod Kone On June 30, 2016, 8:32 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49369/ > ----------------------------------------------------------- > > (Updated June 30, 2016, 8:32 p.m.) > > > Review request for mesos, Adam B and Vinod Kone. > > > Bugs: MESOS-5709 > https://issues.apache.org/jira/browse/MESOS-5709 > > > Repository: mesos > > > Description > ------- > > Previously only /weights was filtered but /roles actually > contains the same information and hence both endpoints > should be filtered in the same way. > As part of this work we renamed the GetWeight action to > ViewRole (and same for the acls). > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > a6d93cd2cb9161a98565b22e50b06aac4931a671 > include/mesos/authorizer/authorizer.proto > fc76796022a6fa3d36a1447c476980868d42c2d0 > src/authorizer/local/authorizer.cpp > 3fade4168face1cb80b30c9b69b31d9eb4126222 > src/common/http.hpp 55bd0ac81af80c656a4a80766a3e4b21db9cf0cf > src/common/http.cpp daf5672287bb6633f468c88632a561f5a01590df > src/master/http.cpp 670b4e0e4424400d138fdf4ca1493520c90b6448 > src/master/weights_handler.cpp 5fc69c6a1c2663bad1774d9376b0aa9f90fa7275 > src/tests/authorization_tests.cpp 9b99da138fa27a725738d70bd99e889b108b44ae > src/tests/dynamic_weights_tests.cpp > c67ed75a050b9db5575ac2bb6100bcf01cfc04ff > src/tests/master_authorization_tests.cpp > 207dfb293ea9b70f439b3b391c3feeba7da10c6a > > Diff: https://reviews.apache.org/r/49369/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Joerg Schad > >
