> On June 23, 2016, 10:30 a.m., Neil Conway wrote: > > Can you write a unit test that verifies the main functional change in this > > review? That is, if the user attempts to create a persistent volume on a > > path that already contains files, the creation fails and the slave exits > > with an error. (We could maybe test the behavior upon restartig the > > slave...)
Added a unit test to check for failed slave recovery if the target checkpoint contains a volume to be CREATEd which has non-empty contents. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48315/#review139231 ----------------------------------------------------------- On June 20, 2016, 11:41 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48315/ > ----------------------------------------------------------- > > (Updated June 20, 2016, 11:41 p.m.) > > > Review request for mesos, Neil Conway and Jiang Yan Xu. > > > Bugs: MESOS-5448 > https://issues.apache.org/jira/browse/MESOS-5448 > > > Repository: mesos > > > Description > ------- > > Root of a MOUNT disk is not deleted on volume DELETE. When we do a > CREATE on a persistent volume and the root directory exists (which > can happen for MOUNT disks), we allow the operation only if the > contents within the root directory is empty. If not, we do not update > the checkpoint with this volume and exit, so as to cleanup when the > slave restarts and handles the CheckpointResourcesMessage. > > > Diffs > ----- > > docs/multiple-disk.md 20b99e0e57360ad43804201b27e593d7ed48ce2c > src/slave/slave.cpp 4bf01f2b020f5e975fb57cffcd19865d7431eac2 > src/tests/persistent_volume_tests.cpp > 5125a8da44759d1235fddac26e9eb5436c3d037b > > Diff: https://reviews.apache.org/r/48315/diff/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
