----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49560/#review140513 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On July 2, 2016, 7:26 p.m., Kevin Klues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49560/ > ----------------------------------------------------------- > > (Updated July 2, 2016, 7:26 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5767 > https://issues.apache.org/jira/browse/MESOS-5767 > > > Repository: mesos > > > Description > ------- > > Added ELFIO as bundled dependency in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 41bd8f427706072786f3ab555012b455d299d1fa > 3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake > fa84e7cd48d61cf30768e6a537db76e47ad8823f > 3rdparty/libprocess/configure.ac 41f4537bd70097057b3017dd94a372672476f5f3 > > Diff: https://reviews.apache.org/r/49560/diff/ > > > Testing > ------- > > Made sure `elfio-3.1` appears in `/build` after running `../configure`, > `make`. > Made sure `elfio` appears in `/include` of installation folder after `make > install`. > > This second one is necessary because `stout` relies on `elfio` in order to > function (similar to how we've done with `picojson.h` in the past). > > > Thanks, > > Kevin Klues > >
