> On July 5, 2016, 3:01 a.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3617 > > <https://reviews.apache.org/r/49616/diff/1/?file=1436564#file1436564line3617> > > > > I think that it is better move this test case above > > `HierarchicalAllocator_BENCHMARK_Test, Metrics` > > > > Also what about rename this test case as > > `HierarchicalAllocator_BENCHMARK_Test, SuppressOffers`
Good suggestions, will add. - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review140714 ----------------------------------------------------------- On July 5, 2016, 6:17 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 6:17 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
