> On July 6, 2016, 11:19 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3587 > > <https://reviews.apache.org/r/49616/diff/2/?file=1437089#file1437089line3587> > > > > We actually don't need this count and it's misleading: it's not the > > count of offers. It's the count of frameworks that are receiving offers in > > this allocation round. > > > > To get the offer count we can use `offers.size()`.
Agreed, removing and using offers.size(). - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49616/#review141095 ----------------------------------------------------------- On July 8, 2016, 3:48 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49616/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 3:48 a.m.) > > > Review request for mesos, James Peach, Joris Van Remoortere, and Jiang Yan Xu. > > > Bugs: MESOS-5781 > https://issues.apache.org/jira/browse/MESOS-5781 > > > Repository: mesos > > > Description > ------- > > - Useful for high framework clusters which carry > many suppressed frameworks that are considered > during allocation. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 0498cd5e54b0e4b87a767585a77699653aa52179 > > Diff: https://reviews.apache.org/r/49616/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
