----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140915 -----------------------------------------------------------
Fix it, then Ship it! src/master/http.cpp (line 1339) <https://reviews.apache.org/r/49489/#comment206281> s/Response/Future<Response> src/master/http.cpp (line 1350) <https://reviews.apache.org/r/49489/#comment206280> Pass argument by const ref. Ditto for the declaration. src/master/http.cpp (line 1371) <https://reviews.apache.org/r/49489/#comment206283> Future<> to be consistent. - Anand Mazumdar On July 1, 2016, 11:42 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49489/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 11:42 p.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The new helper function will be reused by `GET_FRAMEWORKS` and > `GET_STATE` calls. > > > Diffs > ----- > > src/master/http.cpp 7b2f77b9264242f31ab62eb9db7c621a1b8aa2fe > src/master/master.hpp be7cd239c49a0710a29a8187c01484f9f6d615e1 > > Diff: https://reviews.apache.org/r/49489/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Zhitao Li > >
