----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49489/#review140945 -----------------------------------------------------------
Fix it, then Ship it! Would fix these minor style nits while committing. src/master/http.cpp (line 1348) <https://reviews.apache.org/r/49489/#comment206321> Newline before. src/master/http.cpp (line 1350) <https://reviews.apache.org/r/49489/#comment206317> 4 space indent here src/master/http.cpp (line 1383) <https://reviews.apache.org/r/49489/#comment206316> s/mesos::master::Response::GetFrameworks/Future<mesos::master::Response::GetFrameworks> - Anand Mazumdar On July 6, 2016, 1:45 a.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49489/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 1:45 a.m.) > > > Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The new helper function will be reused by `GET_FRAMEWORKS` and > `GET_STATE` calls. > > > Diffs > ----- > > src/master/http.cpp debedd4a4061034a3b55181e93443b9d5e676c52 > src/master/master.hpp 996ff425fc8e9234a5e02560460ad1233dca7061 > > Diff: https://reviews.apache.org/r/49489/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Zhitao Li > >
