> On July 6, 2016, 1:41 a.m., Guangya Liu wrote: > > Another comment is that you may want to add a benchmark test case for this > > smiliar as > > https://github.com/apache/mesos/blob/master/src/tests/hierarchical_allocator_tests.cpp#L3299 > > Yanyan Hu wrote: > Hi, Guangya, thanks a lot for your comments. Will revise the patch per > your suggestion.
@Yanyan, have you published a revised patch? Most of the issues you've marked as fixed are not actually fixed. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review140967 ----------------------------------------------------------- On July 6, 2016, 3:18 a.m., Yanyan Hu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48593/ > ----------------------------------------------------------- > > (Updated July 6, 2016, 3:18 a.m.) > > > Review request for mesos, Alexander Rukletsov, Guangya Liu, and Joris Van > Remoortere. > > > Bugs: MESOS-5425 > https://issues.apache.org/jira/browse/MESOS-5425 > > > Repository: mesos > > > Description > ------- > > This patch reimplement Ranges subtraction using > IntervalSet data type: Ranges values will be > converted to IntervalSet values for subtraction > and the result will be converted back to Ranges > after subtraction is done. This change is for > fixing jira MESOS-5425. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/48593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yanyan Hu > >
