> On July 8, 2016, 10:05 p.m., Joseph Wu wrote: > > src/tests/values_tests.cpp, lines 362-364 > > <https://reviews.apache.org/r/48593/diff/5/?file=1439303#file1439303line362> > > > > Here, you have (closed, open) bounds. > > > > In the implementation, you (correctly) use (closed, closed) bounds. > > Consider normalizing.
Hi, Joseph, thanks a lot for your review. Will make change according to your comment. - Yanyan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48593/#review141348 ----------------------------------------------------------- On July 8, 2016, 1:42 a.m., Yanyan Hu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48593/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 1:42 a.m.) > > > Review request for mesos, Alexander Rukletsov, Guangya Liu, and Joris Van > Remoortere. > > > Bugs: MESOS-5425 > https://issues.apache.org/jira/browse/MESOS-5425 > > > Repository: mesos > > > Description > ------- > > This patch reimplement Ranges subtraction using > IntervalSet data type: Ranges values will be > converted to IntervalSet values for subtraction > and the result will be converted back to Ranges > after subtraction is done. This change is for > fixing jira MESOS-5425. > > > Diffs > ----- > > src/common/values.cpp 587cb68551d438621e215953e89818b623b7f71b > src/tests/values_tests.cpp 929861549e3155c33966896f817f9bf9e6d14354 > > Diff: https://reviews.apache.org/r/48593/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yanyan Hu > >
