----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43471/#review141582 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On April 10, 2016, 10:53 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43471/ > ----------------------------------------------------------- > > (Updated April 10, 2016, 10:53 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Bugs: MESOS-4648 > https://issues.apache.org/jira/browse/MESOS-4648 > > > Repository: mesos > > > Description > ------- > > Currently zookeeper multi-threaded c client doesn't wake up the IO > thread after enqueue auth info message. So the auth info message isn't > flushed util poll timeout. We back port this patch from ZOOKEEPER-770 > to wake up the IO thread in send_info_packet() just as send_ping() > does. > > > Diffs > ----- > > 3rdparty/zookeeper-06d3f3f.patch 56480d5f42b65b5b75e40e5e44666f1db3cf2423 > 3rdparty/zookeeper-3.4.8.patch 486df1ae96af3426835c9d47ff2e36dd47ccde3f > > Diff: https://reviews.apache.org/r/43471/diff/ > > > Testing > ------- > > Before > > ``` > [ OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (10053 > ms) > [ OK ] MasterZooKeeperTest.MasterInfoAddress (11282 ms) > [ OK ] ZooKeeperTest.Auth (6688 ms) > [ OK ] ZooKeeperTest.Create (6690 ms) > ``` > > After > > ``` > [ OK ] ZooKeeperMasterContenderDetectorTest.NonRetryableFrrors (321 ms) > [ OK ] MasterZooKeeperTest.MasterInfoAddress (447 ms) > [ OK ] ZooKeeperTest.Auth (233 ms) > [ OK ] ZooKeeperTest.Create (275 ms) > ``` > > > Thanks, > > haosdent huang > >
