----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/#review141842 -----------------------------------------------------------
3rdparty/libprocess/src/CMakeLists.txt (line 90) <https://reviews.apache.org/r/49924/#comment207240> Same question as the comment in the similar review, #49862. I will quote again here for posterity, in case future contributors need to know the context, but I expect the discussion to carry on there. >Changing the linking structure of this project has a few very important implications for Windows, and we will need to proceed extremely cautiously. Before we get into it, could you please explain explain what the immediate reason for the patch is? It would be helpful also to have this justification captured in the commit description, so that it appears in git log. - Alex Clemmer On July 11, 2016, 8:49 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49924/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 8:49 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > Added libprocess as a shared library. > > > Diffs > ----- > > 3rdparty/libprocess/src/CMakeLists.txt > 6641acf1a0ab62bdb836d5259b885d1a987b45f1 > > Diff: https://reviews.apache.org/r/49924/diff/ > > > Testing > ------- > > cmake .. && make > > With this patch and https://reviews.apache.org/r/49862, Converted libmesos, > http_parser and libprocess to shared libraries and we are using libevent > shared library, zookeeper does not have a shared library in the 3rdparty (I > guess the code is compiled as relocatable) and did not have issues linking. > > > Thanks, > > Srinivas Brahmaroutu > >
