----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49924/#review145062 -----------------------------------------------------------
Patch looks great! Reviews applied: [49688, 49862, 49863, 49870, 49874, 49921, 49924] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Aug. 8, 2016, 5:25 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49924/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2016, 5:25 a.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-5792 > https://issues.apache.org/jira/browse/MESOS-5792 > > > Repository: mesos > > > Description > ------- > > This patch allow to build libprocess as shared library on OSX and Linux > > > Diffs > ----- > > 3rdparty/libprocess/src/CMakeLists.txt > d1547ef6a8762385f653d3824307727e4d0a7e71 > > Diff: https://reviews.apache.org/r/49924/diff/ > > > Testing > ------- > > cmake .. && make > > With this patch and https://reviews.apache.org/r/49862, Converted libmesos, > http_parser and libprocess to shared libraries and we are using libevent > shared library, zookeeper does not have a shared library in the 3rdparty (I > guess the code is compiled as relocatable) and did not have issues linking. > > > Thanks, > > Srinivas Brahmaroutu > >
