----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review141941 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 198 - 199) <https://reviews.apache.org/r/49232/#comment207384> why do you change it as a Future? src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 206) <https://reviews.apache.org/r/49232/#comment207387> As mentioned before, this var is not needed. src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 212 - 221) <https://reviews.apache.org/r/49232/#comment207388> You just need to check isError here. src/slave/containerizer/mesos/provisioner/appc/store.cpp (line 224) <https://reviews.apache.org/r/49232/#comment207389> no need this extra var `manifest`. You can just have _manifest.get() here. src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 403) <https://reviews.apache.org/r/49232/#comment207383> As mentioned before, please fix the indentation. Thanks. - Gilbert Song On July 12, 2016, 9:14 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49232/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 9:14 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added appcManifest to ImageIt nfo and ProvisionInfo. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > e900d752b70165236a198f70c8cb24876a678e4b > src/slave/containerizer/mesos/provisioner/appc/store.cpp > aaa0efe63e587b9e604082b52a3cb8c11545fbb9 > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 48a05059969e068a0ee0d38b61be9e7104e3188d > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 6825742546a87c8148097e6e13a94592e3b6754e > src/slave/containerizer/mesos/provisioner/store.hpp > 1d477ef13ddd24fd8badae0decaa4a2271ecc746 > > Diff: https://reviews.apache.org/r/49232/diff/ > > > Testing > ------- > > Make Check. > > > Thanks, > > Srinivas Brahmaroutu > >
