----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49232/#review140123 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 207 - 208) <https://reviews.apache.org/r/49232/#comment205700> new line here src/slave/containerizer/mesos/provisioner/appc/store.cpp (lines 212 - 213) <https://reviews.apache.org/r/49232/#comment205699> 1) You should add a "'" to the end of the log message. 2) s/image/Appc image 3) Here should check `_manifest.isError()` 4) I prefer `return Error` here to fail fast. if (_manifest.isError()) { return Error( "Failed to get manifest for AppC image '" + appc.SerializeAsString() + "': " + _manifest.error()); } VLOG(1) << "Failed to get manifest for Appc image '" << appc.SerializeAsString() << "'"; src/slave/containerizer/mesos/provisioner/provisioner.hpp (lines 24 - 25) <https://reviews.apache.org/r/49232/#comment205429> new line here src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 334 - 335) <https://reviews.apache.org/r/49232/#comment205695> I think you do not need to add the `APPC` condition here as the current logic is OK. The logic here is handling the case where the docker image is single layer and appc image. if (imageInfo.layers.size() == 1 || image.type() != Image::DOCKER) { return ProvisionInfo{ rootfs, imageInfo.dockerManifest, imageInfo.appcManifest}; } src/slave/containerizer/mesos/provisioner/store.hpp (lines 25 - 26) <https://reviews.apache.org/r/49232/#comment205698> new line here - Guangya Liu On 六月 30, 2016, 6 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49232/ > ----------------------------------------------------------- > > (Updated 六月 30, 2016, 6 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added appcManifest to ImageInfo and ProvisionInfo. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > d984efd4742ec084d66538c48a36ea768832324d > src/slave/containerizer/mesos/provisioner/appc/store.cpp > aaa0efe63e587b9e604082b52a3cb8c11545fbb9 > src/slave/containerizer/mesos/provisioner/provisioner.hpp > 48a05059969e068a0ee0d38b61be9e7104e3188d > src/slave/containerizer/mesos/provisioner/provisioner.cpp > 249acad49122d988e44744384bcf840b941c0997 > src/slave/containerizer/mesos/provisioner/store.hpp > 1d477ef13ddd24fd8badae0decaa4a2271ecc746 > > Diff: https://reviews.apache.org/r/49232/diff/ > > > Testing > ------- > > Make Check. > > > Thanks, > > Srinivas Brahmaroutu > >
