----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49961/#review142022 -----------------------------------------------------------
src/docker/docker.cpp (line 562) <https://reviews.apache.org/r/49961/#comment207490> what about `path::absolute(volume.container_path())`? src/docker/docker.cpp (lines 568 - 570) <https://reviews.apache.org/r/49961/#comment207494> why this does not work if I was using relative path for both? Here the relative container_path will be updated to absolute path above and if the host path is relative path, it means it is using volume from volume driver, why guard this case? src/docker/docker.cpp (lines 571 - 572) <https://reviews.apache.org/r/49961/#comment207491> ditto src/docker/docker.cpp (line 574) <https://reviews.apache.org/r/49961/#comment207495> what about print out the `host_path` and `container_path` in the log message? src/docker/docker.cpp (line 579) <https://reviews.apache.org/r/49961/#comment207493> not yours, but it is better do a clean up here: s/dirver/driver - Guangya Liu On 七月 12, 2016, 4:54 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49961/ > ----------------------------------------------------------- > > (Updated 七月 12, 2016, 4:54 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-5389 > https://issues.apache.org/jira/browse/MESOS-5389 > > > Repository: mesos > > > Description > ------- > > Supported relative container path in docker containerizer. > > > Diffs > ----- > > src/docker/docker.cpp aad5380f5848f1b49d5524032f3b5b18c2aa1c56 > > Diff: https://reviews.apache.org/r/49961/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
