> On July 13, 2016, 7:08 a.m., Guangya Liu wrote: > > src/docker/docker.cpp, lines 568-570 > > <https://reviews.apache.org/r/49961/diff/1/?file=1442433#file1442433line568> > > > > why this does not work if I was using relative path for both? Here the > > relative container_path will be updated to absolute path above and if the > > host path is relative path, it means it is using volume from volume driver, > > why guard this case?
I think volume driver is being deprecated. The logics here was hacky from the very begining. Since relative container_path is not support anyway previously, let's don't introduce a behavior that we will deprecate soon. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49961/#review142022 ----------------------------------------------------------- On July 12, 2016, 4:54 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49961/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 4:54 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Bugs: MESOS-5389 > https://issues.apache.org/jira/browse/MESOS-5389 > > > Repository: mesos > > > Description > ------- > > Supported relative container path in docker containerizer. > > > Diffs > ----- > > src/docker/docker.cpp aad5380f5848f1b49d5524032f3b5b18c2aa1c56 > > Diff: https://reviews.apache.org/r/49961/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
