----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50016/#review142193 -----------------------------------------------------------
Patch looks great! Reviews applied: [50016] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On July 14, 2016, 6:13 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50016/ > ----------------------------------------------------------- > > (Updated July 14, 2016, 6:13 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-5846 > https://issues.apache.org/jira/browse/MESOS-5846 > > > Repository: mesos > > > Description > ------- > > This test case is flaky because we didn't wait for the agent receives > and properly handles the ACK of `TASK_KILLED`. Then the agent may have > not yet marked the task completed when we perform the query. > > > Diffs > ----- > > src/tests/api_tests.cpp b4a6c46cd3e0e57b4f4d22d2103d3947c592e133 > > Diff: https://reviews.apache.org/r/50016/diff/ > > > Testing > ------- > > Repeat test in my env. > ``` > sudo GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="ContentType/AgentAPITest.GetState/0" --verbose > --gtest_repeat=1000 > ``` > > > Thanks, > > haosdent huang > >
