----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142254 -----------------------------------------------------------
src/local/flags.hpp (line 36) <https://reviews.apache.org/r/50003/#comment207798> This keeps the newlines here consistent with other help strings, but it does look a bit messy. Perhaps we should move the newlines to accommodate the line wrapping here? src/local/flags.hpp (line 39) <https://reviews.apache.org/r/50003/#comment207797> s/masters/masters and agents/ src/local/flags.hpp (line 41) <https://reviews.apache.org/r/50003/#comment207796> `/var/lib/mesos` might be more appropriate here, since this isn't master or agent specific? - Greg Mann On July 13, 2016, 8:54 p.m., Ammar Askar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50003/ > ----------------------------------------------------------- > > (Updated July 13, 2016, 8:54 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5613 > https://issues.apache.org/jira/browse/MESOS-5613 > > > Repository: mesos > > > Description > ------- > > Propagate work_dir flag from local runs to agents/masters. > > > Diffs > ----- > > src/local/flags.hpp f0af0d251e004f305726e7e4fe7941c2d4081183 > src/local/local.cpp a543aef117fea62660d55435be4d66d30f8ee860 > > Diff: https://reviews.apache.org/r/50003/diff/ > > > Testing > ------- > > Manually tested that `mesos local` and `mesos-local` run now. Not sure if a > regression test for this would be good, please advise. > > > Thanks, > > Ammar Askar > >
