> On July 15, 2016, 5:41 p.m., Greg Mann wrote: > > src/local/flags.hpp, line 33 > > <https://reviews.apache.org/r/50003/diff/2/?file=1444262#file1444262line33> > > > > I was originally put off by the duplication of the `work_dir` flag > > here, since it makes `work_dir` the only normal Mesos master/agent flag > > that can be specified at the command line. Another option I see is to > > manually check the value of `MESOS_WORK_DIR` and then set it via > > `flags.work_dir = DEFAULT` if necessary. However, I think I prefer the > > method of using our flag objects to express the default value rather than > > manually checking an environment variable. > > > > Anyway! What do you think about adding a comment here explaining why > > we're doing this for `work_dir` but not any other flag? i.e., we need to > > set `work_dir` early because it's a required flag and `load` will barf if > > it's not already set. Local mode is the one case in which we deem it > > acceptable to use a default location within `/tmp` for the `work_dir`.
>since it makes work_dir the only normal Mesos master/agent flag that can be >specified at the command line. Sure but that's just for now, in the future this could be expanded to pass down any flags to the agents/master from `local` >Anyway! What do you think about adding a comment here explaining why we're >doing this for work_dir but not any other flag? i.e., we need to set work_dir >early because it's a required flag and load will barf if it's not already set. >Local mode is the one case in which we deem it acceptable to use a default >location within /tmp for the work_dir. Done - Ammar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50003/#review142393 ----------------------------------------------------------- On July 15, 2016, 9:01 p.m., Ammar Askar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50003/ > ----------------------------------------------------------- > > (Updated July 15, 2016, 9:01 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-5613 > https://issues.apache.org/jira/browse/MESOS-5613 > > > Repository: mesos > > > Description > ------- > > Propagate work_dir flag from local runs to agents/masters. > > > Diffs > ----- > > src/local/flags.hpp f0af0d2 > src/local/local.cpp a543aef > src/tests/test_framework_test.sh 617ca52 > > Diff: https://reviews.apache.org/r/50003/diff/ > > > Testing > ------- > > Manually tested that `mesos local` and `mesos-local` run now. Not sure if a > regression test for this would be good, please advise. > > > Thanks, > > Ammar Askar > >
