> On July 13, 2016, 10:09 a.m., Neil Conway wrote: > > src/tests/api_tests.cpp, line 95 > > <https://reviews.apache.org/r/49914/diff/1/?file=1441531#file1441531line95> > > > > Rather than changing this for all tests implicitly, I'd prefer creating > > a `master::Flags` and changing the allocation interval explicitly in the > > tests that benefit from it.
Ok.. I was working over this. Do you mean to say to write a createMasterFlags() in tests/mesos.hpp as inline function and use that instead of current virtual function? It needs a long streak of small changes in many of the current tests. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review142046 ----------------------------------------------------------- On July 11, 2016, 7:39 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49914/ > ----------------------------------------------------------- > > (Updated July 11, 2016, 7:39 p.m.) > > > Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone. > > > Bugs: MESOS-5732 > https://issues.apache.org/jira/browse/MESOS-5732 > > > Repository: mesos > > > Description > ------- > > Overloaded createMasterFlags in MasterAPITest to increase > the speed of 'MasterAPITest.ReserveResources' and > 'MasterAPITest.UnreserveResources'. > > > Diffs > ----- > > src/tests/api_tests.cpp 55e825ea6a3bd43c76dc67e8b90a97e8c9530a47 > > Diff: https://reviews.apache.org/r/49914/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo make -j4 check > > > Thanks, > > Abhishek Dasgupta > >
