> On July 19, 2016, 12:57 a.m., Vinod Kone wrote: > > This change looks ok to me and indepdendent of the previous 2 reviews in > > the chain. If yes, I'm happy to commit this if you remove the dependency. > > You might be able to discard the first 2 reviews even.
I discarded the first one, but for 2nd one I put a comment. I would discard or update that patch based on your reply. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49914/#review142674 ----------------------------------------------------------- On July 18, 2016, 8:20 a.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49914/ > ----------------------------------------------------------- > > (Updated July 18, 2016, 8:20 a.m.) > > > Review request for mesos, Anand Mazumdar, Neil Conway, and Vinod Kone. > > > Bugs: MESOS-5732 > https://issues.apache.org/jira/browse/MESOS-5732 > > > Repository: mesos > > > Description > ------- > > In this patch, speed of 'MasterAPITest.UnreserveResources' > is increased by removing the unnecessary check for unreserved > resources which is already verified in > 'MasterAPITest.ReserveResources' and thus by removing the > delay for waiting for the resource offers to be declined. > > > Diffs > ----- > > src/tests/api_tests.cpp 37bf2866e1dbf7a8bead0c93825666921f4228fb > > Diff: https://reviews.apache.org/r/49914/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo make -j4 check > > > Thanks, > > Abhishek Dasgupta > >
