> On June 24, 2016, 8:41 p.m., Joseph Wu wrote: > > src/CMakeLists.txt, line 462 > > <https://reviews.apache.org/r/49178/diff/1/?file=1429049#file1429049line462> > > > > Would it be worthwhile to get rid of the "Debug" and "Release" build > > configuration folders too? > > > > i.e. > > ``` > > SET(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG ${CMAKE_BINARY_DIR}/src) > > SET(CMAKE_RUNTIME_OUTPUT_DIRECTORY_RELEASE ${CMAKE_BINARY_DIR}/src) > > ``` > > > > See: > > https://cmake.org/cmake/help/v3.5/prop_tgt/RUNTIME_OUTPUT_DIRECTORY_CONFIG.html
Agree - Daniel ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49178/#review139399 ----------------------------------------------------------- On June 24, 2016, 4:04 a.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49178/ > ----------------------------------------------------------- > > (Updated June 24, 2016, 4:04 a.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Configured single output binary folder. > > > Diffs > ----- > > src/CMakeLists.txt ecdeee75abfca944bc2ac1da4962d8d50e236d2d > > Diff: https://reviews.apache.org/r/49178/diff/ > > > Testing > ------- > > Windows: build/run > > > Thanks, > > Daniel Pravat > >
