----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49178/#review142429 -----------------------------------------------------------
Fix it, then Ship it! As this is a small change, I'll make the changes we agreed upon before committing. src/CMakeLists.txt (line 460) <https://reviews.apache.org/r/49178/#comment207992> Nit: not all caps + period at the end. src/CMakeLists.txt (lines 461 - 463) <https://reviews.apache.org/r/49178/#comment207994> This would be nice to have on non-Windows builds too. I'll add the `Debug`/`Release` flattening for Windows-only though. - Joseph Wu On June 23, 2016, 9:04 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49178/ > ----------------------------------------------------------- > > (Updated June 23, 2016, 9:04 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Configured single output binary folder. > > > Diffs > ----- > > src/CMakeLists.txt ecdeee75abfca944bc2ac1da4962d8d50e236d2d > > Diff: https://reviews.apache.org/r/49178/diff/ > > > Testing > ------- > > Windows: build/run > > > Thanks, > > Daniel Pravat > >
