----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/#review142517 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (line 126) <https://reviews.apache.org/r/49824/#comment208074> Why is this a virtual method? src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 484 - 485) <https://reviews.apache.org/r/49824/#comment208076> I would suggest to make this consistent with the warning message below in `_usage`, i.e.: ``` "Failed to get the usage information of container '" + stringify(containerId) + "': Unknown container" ``` src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (lines 494 - 498) <https://reviews.apache.org/r/49824/#comment208078> I think we should use `await()` rather than `collect()` so that we can return partial usage statistics. And I think we do not need a `defer()` here, instead a `lambda::bind()` should be enough. Please take a look at the following code as a reference: https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/containerizer.cpp#L1532:L1535 src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp (line 506) <https://reviews.apache.org/r/49824/#comment208075> I think you should check `!isReady()` rather than `isFailed()`. - Qian Zhang On July 15, 2016, 11:33 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49824/ > ----------------------------------------------------------- > > (Updated July 15, 2016, 11:33 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::usage`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > c57baec88437f68886702a40ec8a6a6458546119 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 4a9f55bf3b217405bf90943f27a976422877a99e > > Diff: https://reviews.apache.org/r/49824/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
