> On July 24, 2016, 9:05 p.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp, line 475 > > <https://reviews.apache.org/r/49824/diff/6/?file=1450008#file1450008line475> > > > > s/Skipping get/Skipping/
Second thought, to be consistent with the code here: https://github.com/apache/mesos/blob/1.0.0-rc4/src/slave/containerizer/mesos/containerizer.cpp#L1496, I think we should do: `s/Skipping get the usage information of container/Skipping resource statistic for container/`. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49824/#review143329 ----------------------------------------------------------- On July 22, 2016, 3:07 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49824/ > ----------------------------------------------------------- > > (Updated July 22, 2016, 3:07 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5041 > https://issues.apache.org/jira/browse/MESOS-5041 > > > Repository: mesos > > > Description > ------- > > Implemented `CgroupsIsolatorProcess::usage`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 4a9f55bf3b217405bf90943f27a976422877a99e > > Diff: https://reviews.apache.org/r/49824/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
