> On 七月 18, 2016, 7:12 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 3364-3365 > > <https://reviews.apache.org/r/50115/diff/1/?file=1445571#file1445571line3364> > > > > Replacing sleep with settle sounds good! Why not keep the 'finished' > > variable so that we can ensure the settle is doing what we expect? > > > > ``` > > // Wait for all the `addSlave` operations to be processed. > > Clock::settle(); > > > > ASSERT_EQ(slaveCount, offerCallbacks.load()); > > ``` > > > > Note that 'finished' is a bit vague, perhaps offerCallbacks is clearer?
Thanks Ben, I was putting `ASSERT_EQ(slaveCount, offerCallbacks.load());` under `watch.stop()` to make sure we got an accurate elapse time for this, hope it is OK. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/#review142608 ----------------------------------------------------------- On 七月 18, 2016, 3:32 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50115/ > ----------------------------------------------------------- > > (Updated 七月 18, 2016, 3:32 a.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, Klaus Ma, and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Currently, in HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave, > we are using `sleep` to check if the operations are processed, this > is not accurate, we should use `Clock::settle()` instead. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > ce5da6be490b6fce311286eb4018c91eef55067e > > Diff: https://reviews.apache.org/r/50115/diff/ > > > Testing > ------- > > make > make check > > ``` > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test > [ RUN ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 > Using 1000 agents and 50 frameworks > Added 50 frameworks in 14624us > Added 1000 agents in 2.253886secs > Updated 1000 agents in 1.940139secs > [ OK ] > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 > (4493 ms) > [----------] 1 test from > SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (4495 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (4520 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Guangya Liu > >
