----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50115/ -----------------------------------------------------------
(Updated 七月 18, 2016, 10:16 p.m.) Review request for mesos, Benjamin Mahler, Jie Yu, Klaus Ma, and Jiang Yan Xu. Repository: mesos Description ------- Currently, in HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave, we are using `sleep` to check if the operations are processed, this is not accurate, we should use `Clock::settle()` instead. Diffs (updated) ----- src/tests/hierarchical_allocator_tests.cpp 65c3fe6761ccb1ec7d5fbca9a78b2c62e11885ca Diff: https://reviews.apache.org/r/50115/diff/ Testing ------- make make check ``` [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test [ RUN ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 Using 1000 agents and 50 frameworks Added 50 frameworks in 14624us Added 1000 agents in 2.253886secs Updated 1000 agents in 1.940139secs [ OK ] SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test.AddAndUpdateSlave/1 (4493 ms) [----------] 1 test from SlaveAndFrameworkCount/HierarchicalAllocator_BENCHMARK_Test (4495 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (4520 ms total) [ PASSED ] 1 test. ``` Thanks, Guangya Liu
