> On July 20, 2016, 10:26 p.m., Jie Yu wrote: > > src/launcher/fetcher.cpp, lines 512-514 > > <https://reviews.apache.org/r/50199/diff/3/?file=1448381#file1448381line512> > > > > Can we instead use: > > ``` > > CHECK_SOME(createCacheDirectory(fetcherInfo.get())) > > << "..."; > > ```
I changed this to an `EXIT` statement, per your suggestion on the following patch. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/#review142997 ----------------------------------------------------------- On July 20, 2016, 11:01 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50199/ > ----------------------------------------------------------- > > (Updated July 20, 2016, 11:01 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Joerg Schad. > > > Bugs: MESOS-5845 > https://issues.apache.org/jira/browse/MESOS-5845 > > > Repository: mesos > > > Description > ------- > > The fetcher's launcher creates the fetcher cache > directory for each user immediately before an artifact > is fetched. In order to allow this directory to be > created by a different user than the user doing the > fetching, this patch factors out this directory > creation and places it before all fetches occur. > > > Diffs > ----- > > src/launcher/fetcher.cpp 0539b0182bd4a7178f103dddd1ab4fee8fc79eda > > Diff: https://reviews.apache.org/r/50199/diff/ > > > Testing > ------- > > `sudo make check` on both OSX and CentOS 7 was done at the end of this patch > chain. > > > Thanks, > > Greg Mann > >
