> On July 20, 2016, 8:14 a.m., Joerg Schad wrote: > > src/launcher/fetcher.cpp, line 436 > > <https://reviews.apache.org/r/50199/diff/2/?file=1447745#file1447745line436> > > > > Do we really want to check and fail on this condition? In the previous > > iteration you would have skipped creating the directory in that case. > > Also judging from the code `` const Option<string> cacheDirectory = > > fetcherInfo.get().has_cache_directory() ? > > Option<string>::some(fetcherInfo.get().cache_directory()) : > > Option<string>::none();``` below, it seems it is valid that > > there is no cache_directory.
just seen your comment on the previous patch set. Does it in that case make sense to add a check and change the logic of the above mentioned code? - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50199/#review142913 ----------------------------------------------------------- On July 19, 2016, 11:10 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50199/ > ----------------------------------------------------------- > > (Updated July 19, 2016, 11:10 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, and Joerg Schad. > > > Bugs: MESOS-5845 > https://issues.apache.org/jira/browse/MESOS-5845 > > > Repository: mesos > > > Description > ------- > > The fetcher's launcher creates the fetcher cache > directory for each user immediately before an artifact > is fetched. In order to allow this directory to be > created by a different user than the user doing the > fetching, this patch factors out this directory > creation and places it before all fetches occur. > > > Diffs > ----- > > src/launcher/fetcher.cpp 0539b0182bd4a7178f103dddd1ab4fee8fc79eda > > Diff: https://reviews.apache.org/r/50199/diff/ > > > Testing > ------- > > `sudo make check` on both OSX and CentOS 7 was done at the end of this patch > chain. > > > Thanks, > > Greg Mann > >
