----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49851/#review143517 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp (lines 71 - 75) <https://reviews.apache.org/r/49851/#comment209491> I think this should not be a virtual method, and it may be better to put it after the `cleanup()` method. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 81) <https://reviews.apache.org/r/49851/#comment209492> This comment needs to be updated since now the parameter is `_notifyCallback` rather than `_isolator`. src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 83) <https://reviews.apache.org/r/49851/#comment209493> Does it have to be a virtual method? src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp (line 174) <https://reviews.apache.org/r/49851/#comment209494> s/that uses/that is used/ src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 391) <https://reviews.apache.org/r/49851/#comment209496> I think here you should use `limitSwap` rather than `flags.cgroups_limit_swap`. src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 494) <https://reviews.apache.org/r/49851/#comment209499> How do we recover this field `updatedLimit`? I mean during agent recovery, `updatedLimit` of each Info will be reset to `false`, right? But I think that is not correct. src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp (line 683) <https://reviews.apache.org/r/49851/#comment209505> I think you also need to do `infos.erase(containerId);` here. - Qian Zhang On July 27, 2016, 1:13 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49851/ > ----------------------------------------------------------- > > (Updated July 27, 2016, 1:13 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5045 > https://issues.apache.org/jira/browse/MESOS-5045 > > > Repository: mesos > > > Description > ------- > > Implemented `MemorySubsystem`. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp > c57baec88437f68886702a40ec8a6a6458546119 > src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp > 348f105f9c3109a02f1dde0649f1b829cb9ddd04 > src/slave/containerizer/mesos/isolators/cgroups/subsystem.hpp > 5f52a076a1fa3a21d886cb961ddeed5046a38d7c > src/slave/containerizer/mesos/isolators/cgroups/subsystem.cpp > a30ecafcbecc9d3b6eeea2b04dcb4d278750af41 > > Diff: https://reviews.apache.org/r/49851/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
